Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: clean the usage of deprecated state and its storage #1133

Merged
merged 1 commit into from
May 27, 2024

Conversation

healthjyk
Copy link
Contributor

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?


Additional documentation e.g., design docs, usage docs, etc.:


@healthjyk healthjyk requested a review from liu-hm19 May 23, 2024 08:23
@healthjyk healthjyk self-assigned this May 23, 2024
@coveralls
Copy link

coveralls commented May 23, 2024

Pull Request Test Coverage Report for Build 9206077736

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 10 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.001%) to 54.35%

Files with Coverage Reduction New Missed Lines %
pkg/engine/operation/parser/parser.go 3 79.27%
pkg/cmd/apply/apply.go 7 48.08%
Totals Coverage Status
Change from base Build 9201901133: 0.001%
Covered Lines: 8834
Relevant Lines: 16254

💛 - Coveralls

@healthjyk healthjyk changed the title cleanup: clean the usage of deprecated state and its storage feat: clean the usage of deprecated state and its storage May 23, 2024
Copy link
Contributor

@liu-hm19 liu-hm19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@liu-hm19 liu-hm19 merged commit 272ee0d into KusionStack:main May 27, 2024
6 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators May 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants