Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add a command 'mod add' #1136

Merged
merged 1 commit into from
May 29, 2024
Merged

Conversation

SparkYuan
Copy link
Member

What type of PR is this?

/kind feature

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #1009

Special notes for your reviewer:

Does this PR introduce a user-facing change?


Additional documentation e.g., design docs, usage docs, etc.:


@SparkYuan SparkYuan requested a review from liu-hm19 May 28, 2024 07:27
@coveralls
Copy link

coveralls commented May 28, 2024

Pull Request Test Coverage Report for Build 9265238373

Details

  • 43 of 89 (48.31%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.03%) to 54.313%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/cmd/mod/mod.go 0 1 0.0%
pkg/cmd/mod/push.go 0 1 0.0%
pkg/cmd/mod/list.go 5 7 71.43%
pkg/cmd/mod/add.go 37 79 46.84%
Totals Coverage Status
Change from base Build 9265142956: -0.03%
Covered Lines: 8871
Relevant Lines: 16333

💛 - Coveralls

@SparkYuan SparkYuan enabled auto-merge (squash) May 28, 2024 07:47
Copy link
Contributor

@liu-hm19 liu-hm19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@SparkYuan SparkYuan merged commit fc20b33 into KusionStack:main May 29, 2024
6 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators May 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feat: add 'kusion mod add' to download a specific module that can be initialized in the AppConfiguration.
4 participants