Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: probe type judgment in conversion from kusion probe to k8s probe #1144

Merged
merged 1 commit into from
Jun 5, 2024

Conversation

Liuxingyu1111111
Copy link
Contributor

@Liuxingyu1111111 Liuxingyu1111111 commented Jun 5, 2024

What type of PR is this?

/kind bug

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #1144

Special notes for your reviewer:

Does this PR introduce a user-facing change?


Additional documentation e.g., design docs, usage docs, etc.:


Copy link

github-actions bot commented Jun 5, 2024

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@Liuxingyu1111111
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@Liuxingyu1111111 Liuxingyu1111111 force-pushed the 1143-fix-bug-in-convertkusionprobetov1probe branch from b7d0624 to 8740aee Compare June 5, 2024 08:54
@Liuxingyu1111111 Liuxingyu1111111 force-pushed the 1143-fix-bug-in-convertkusionprobetov1probe branch from 8740aee to 8057870 Compare June 5, 2024 09:03
@coveralls
Copy link

coveralls commented Jun 5, 2024

Pull Request Test Coverage Report for Build 9381273358

Details

  • 5 of 5 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 54.375%

Totals Coverage Status
Change from base Build 9379907733: 0.02%
Covered Lines: 9103
Relevant Lines: 16741

💛 - Coveralls

Copy link
Member

@SparkYuan SparkYuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

revise your commit msg

Copy link
Member

@SparkYuan SparkYuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please revise your commit message to be more understandable

@Liuxingyu1111111 Liuxingyu1111111 force-pushed the 1143-fix-bug-in-convertkusionprobetov1probe branch from c9780b0 to ba9e3ba Compare June 5, 2024 09:34
@coveralls
Copy link

coveralls commented Jun 5, 2024

Pull Request Test Coverage Report for Build 9381669893

Details

  • 5 of 5 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 54.358%

Totals Coverage Status
Change from base Build 9379907733: 0.0%
Covered Lines: 9100
Relevant Lines: 16741

💛 - Coveralls

@Liuxingyu1111111 Liuxingyu1111111 changed the title fix: convertkusionprobetov1probe fix: probe type judgment in conversion from kusion probe to k8s probe Jun 5, 2024
@coveralls
Copy link

coveralls commented Jun 5, 2024

Pull Request Test Coverage Report for Build 9381739382

Details

  • 5 of 5 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.006%) to 54.364%

Totals Coverage Status
Change from base Build 9379907733: 0.006%
Covered Lines: 9101
Relevant Lines: 16741

💛 - Coveralls

@SparkYuan SparkYuan enabled auto-merge (squash) June 5, 2024 09:42
@SparkYuan SparkYuan merged commit c31e1f7 into main Jun 5, 2024
8 checks passed
@SparkYuan SparkYuan deleted the 1143-fix-bug-in-convertkusionprobetov1probe branch June 5, 2024 09:44
@github-actions github-actions bot locked and limited conversation to collaborators Jun 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants