Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set the release phase as failed when exit apply prompt #1148

Merged
merged 1 commit into from
Jun 6, 2024

Conversation

liu-hm19
Copy link
Contributor

@liu-hm19 liu-hm19 commented Jun 6, 2024

What type of PR is this?

/kind bug

What this PR does / why we need it:

This PR sets the release phase as failed when exit the prompt of kusion apply due to SIGINT or SIGTERM.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?


Additional documentation e.g., design docs, usage docs, etc.:


@liu-hm19 liu-hm19 added the kind/bug Something isn't working label Jun 6, 2024
@liu-hm19 liu-hm19 added this to the v0.12.0 milestone Jun 6, 2024
@liu-hm19 liu-hm19 requested a review from SparkYuan June 6, 2024 08:30
@liu-hm19 liu-hm19 self-assigned this Jun 6, 2024
Copy link
Member

@SparkYuan SparkYuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@coveralls
Copy link

coveralls commented Jun 6, 2024

Pull Request Test Coverage Report for Build 9397654679

Details

  • 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • 7 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.04%) to 54.318%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/cmd/apply/apply.go 0 1 0.0%
Files with Coverage Reduction New Missed Lines %
pkg/cmd/destroy/destroy.go 7 49.82%
Totals Coverage Status
Change from base Build 9396235994: -0.04%
Covered Lines: 9095
Relevant Lines: 16744

💛 - Coveralls

@liu-hm19 liu-hm19 merged commit 389d3ee into KusionStack:main Jun 6, 2024
8 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jun 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants