Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update the init and stack create scaffolding templates #1149

Merged
merged 1 commit into from
Jun 6, 2024

Conversation

liu-hm19
Copy link
Contributor

@liu-hm19 liu-hm19 commented Jun 6, 2024

What type of PR is this?

/kind feature

What this PR does / why we need it:

This PR updates the scaffolding templates for kusion init and kusion stack create.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?


Additional documentation e.g., design docs, usage docs, etc.:


@liu-hm19 liu-hm19 added the kind/feature Categorizes issue or PR as related to a new feature label Jun 6, 2024
@liu-hm19 liu-hm19 added this to the v0.12.0 milestone Jun 6, 2024
@liu-hm19 liu-hm19 requested a review from SparkYuan June 6, 2024 09:35
@liu-hm19 liu-hm19 self-assigned this Jun 6, 2024
@coveralls
Copy link

coveralls commented Jun 6, 2024

Pull Request Test Coverage Report for Build 9398566889

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 10 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.05%) to 54.324%

Files with Coverage Reduction New Missed Lines %
pkg/engine/operation/parser/parser.go 3 79.27%
pkg/cmd/destroy/destroy.go 7 49.82%
Totals Coverage Status
Change from base Build 9398270454: -0.05%
Covered Lines: 9096
Relevant Lines: 16744

💛 - Coveralls

Copy link
Member

@SparkYuan SparkYuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@SparkYuan SparkYuan merged commit db5886a into KusionStack:main Jun 6, 2024
8 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jun 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/feature Categorizes issue or PR as related to a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants