Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix version format to match semantic versioning 2.0.0 #119

Merged
merged 1 commit into from
Aug 11, 2022

Conversation

howieyuen
Copy link
Collaborator

@howieyuen howieyuen commented Aug 10, 2022

ref: https://semver.org/

from packaging import version

print(version.parse("v0.3.22-2abnsx"))  # Invalid version: v0.3.22-2abnsx 
print(version.parse("v0.3.22.2abnsx"))  # Invalid version: v0.3.22.2abnsx
print(version.parse("v0.3.22+2abnsx")) # Valid version: 0.3.22+2abnsx

print(version.parse("v0.3.22-alpha.01-2abnsx")) # Invalid version: v0.3.22-alpha.01-2abnsx
print(version.parse("v0.3.22-alpha.01.2abnsx")) # Invalid version: v0.3.22-alpha.01.2abnsx
print(version.parse("v0.3.22-alpha.01+2abnsx")) # Valid version: 0.3.22a1+2abnsx 

print(version.parse("v0.3.22-beta.02-2abnsx")) # Invalid version: v0.3.22-beta.02-2abnsx
print(version.parse("v0.3.22-beta.02.2abnsx")) # Invalid version: v0.3.22-beta.02.2abnsx
print(version.parse("v0.3.22-beta.02+2abnsx")) # Valid version: 0.3.22b2+2abnsx

print(version.parse("v0.3.22-rc.0-2abnsx")) # Invalid version: v0.3.22-rc.0-2abnsx
print(version.parse("v0.3.22-rc.0.2abnsx")) # Invalid version: v0.3.22-rc.0.2abnsx
print(version.parse("v0.3.22-rc.0+2abnsx")) # Valid version: 0.3.22rc0+2abnsx

@howieyuen howieyuen requested a review from a team August 10, 2022 09:01
@howieyuen howieyuen added the cli label Aug 10, 2022
@howieyuen howieyuen added this to the v0.6.0 milestone Aug 10, 2022
Copy link
Contributor

@markliby markliby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@howieyuen howieyuen self-assigned this Aug 11, 2022
Copy link
Contributor

@elliotxx elliotxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@howieyuen howieyuen merged commit fb656aa into main Aug 11, 2022
@howieyuen howieyuen deleted the howieyuen-patch-1 branch August 11, 2022 07:18
@github-actions github-actions bot locked and limited conversation to collaborators Aug 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants