Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable concurrent manipulation of TF resources since they are stored in different directories #1194

Merged
merged 1 commit into from
Jul 3, 2024

Conversation

SparkYuan
Copy link
Member

@SparkYuan SparkYuan commented Jun 28, 2024

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #1195

Special notes for your reviewer:

Does this PR introduce a user-facing change?


Additional documentation e.g., design docs, usage docs, etc.:


@SparkYuan SparkYuan force-pushed the tf-runtime branch 2 times, most recently from dec78c0 to 1e31d93 Compare June 28, 2024 08:22
@SparkYuan SparkYuan changed the title Tf runtime feat: enable concurrent manipulation of TF resources since they are stored in different directories Jun 28, 2024
@coveralls
Copy link

coveralls commented Jun 28, 2024

Pull Request Test Coverage Report for Build 9709787430

Details

  • 2 of 3 (66.67%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.06%) to 54.083%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/engine/runtime/terraform/terraform_runtime.go 0 1 0.0%
Totals Coverage Status
Change from base Build 9709696024: 0.06%
Covered Lines: 9120
Relevant Lines: 16863

💛 - Coveralls

@SparkYuan SparkYuan added the kind/feature Categorizes issue or PR as related to a new feature label Jul 1, 2024
@SparkYuan SparkYuan force-pushed the tf-runtime branch 2 times, most recently from 6148d0e to 64e24d6 Compare July 2, 2024 12:44
@coveralls
Copy link

coveralls commented Jul 2, 2024

Pull Request Test Coverage Report for Build 9761159087

Details

  • 22 of 40 (55.0%) changed or added relevant lines in 2 files are covered.
  • 4 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.02%) to 54.487%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/engine/runtime/terraform/tfops/workspace.go 7 13 53.85%
pkg/engine/runtime/terraform/terraform_runtime.go 15 27 55.56%
Files with Coverage Reduction New Missed Lines %
pkg/engine/operation/watch.go 1 82.76%
pkg/engine/operation/parser/parser.go 3 79.27%
Totals Coverage Status
Change from base Build 9710950045: -0.02%
Covered Lines: 9339
Relevant Lines: 17140

💛 - Coveralls

@coveralls
Copy link

coveralls commented Jul 2, 2024

Pull Request Test Coverage Report for Build 9761198738

Details

  • 22 of 40 (55.0%) changed or added relevant lines in 2 files are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.01%) to 54.492%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/engine/runtime/terraform/tfops/workspace.go 7 13 53.85%
pkg/engine/runtime/terraform/terraform_runtime.go 15 27 55.56%
Files with Coverage Reduction New Missed Lines %
pkg/engine/operation/parser/parser.go 3 79.27%
Totals Coverage Status
Change from base Build 9710950045: -0.01%
Covered Lines: 9340
Relevant Lines: 17140

💛 - Coveralls

@coveralls
Copy link

coveralls commented Jul 2, 2024

Pull Request Test Coverage Report for Build 9761296428

Details

  • 22 of 40 (55.0%) changed or added relevant lines in 2 files are covered.
  • 11 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.06%) to 54.446%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/engine/runtime/terraform/tfops/workspace.go 7 13 53.85%
pkg/engine/runtime/terraform/terraform_runtime.go 15 27 55.56%
Files with Coverage Reduction New Missed Lines %
pkg/engine/operation/watch.go 1 82.76%
pkg/engine/operation/parser/spec_parser.go 4 56.1%
pkg/engine/operation/parser/parser.go 6 75.61%
Totals Coverage Status
Change from base Build 9710950045: -0.06%
Covered Lines: 9332
Relevant Lines: 17140

💛 - Coveralls

@coveralls
Copy link

coveralls commented Jul 3, 2024

Pull Request Test Coverage Report for Build 9771565863

Details

  • 32 of 49 (65.31%) changed or added relevant lines in 2 files are covered.
  • 4 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.01%) to 54.516%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/engine/runtime/terraform/tfops/workspace.go 17 22 77.27%
pkg/engine/runtime/terraform/terraform_runtime.go 15 27 55.56%
Files with Coverage Reduction New Missed Lines %
pkg/engine/runtime/terraform/tfops/workspace.go 1 59.53%
pkg/engine/operation/parser/parser.go 3 79.27%
Totals Coverage Status
Change from base Build 9710950045: 0.01%
Covered Lines: 9349
Relevant Lines: 17149

💛 - Coveralls

@coveralls
Copy link

coveralls commented Jul 3, 2024

Pull Request Test Coverage Report for Build 9774546038

Details

  • 32 of 50 (64.0%) changed or added relevant lines in 2 files are covered.
  • 5 unchanged lines in 3 files lost coverage.
  • Overall coverage remained the same at 54.504%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/engine/runtime/terraform/tfops/workspace.go 17 22 77.27%
pkg/engine/runtime/terraform/terraform_runtime.go 15 28 53.57%
Files with Coverage Reduction New Missed Lines %
pkg/engine/operation/watch.go 1 82.76%
pkg/engine/runtime/terraform/tfops/workspace.go 1 59.53%
pkg/engine/operation/parser/parser.go 3 79.27%
Totals Coverage Status
Change from base Build 9710950045: 0.0%
Covered Lines: 9348
Relevant Lines: 17151

💛 - Coveralls

@SparkYuan SparkYuan requested a review from ffforest July 3, 2024 09:54
@SparkYuan SparkYuan enabled auto-merge (squash) July 3, 2024 09:54
@SparkYuan SparkYuan merged commit 1ba096b into KusionStack:main Jul 3, 2024
7 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jul 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/feature Categorizes issue or PR as related to a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: enable concurrent manipulation of TF resources since they are stored in different directories
3 participants