Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: deep copy resource attributes #1216

Merged
merged 2 commits into from
Jul 18, 2024
Merged

Conversation

liu-hm19
Copy link
Contributor

What type of PR is this?

/kind bug

What this PR does / why we need it:

This PR fixes a bug of deep copying resource attributes when getting the diff report.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?


Additional documentation e.g., design docs, usage docs, etc.:


@liu-hm19 liu-hm19 added the kind/bug Something isn't working label Jul 11, 2024
@liu-hm19 liu-hm19 added this to the v0.12.1 milestone Jul 11, 2024
@liu-hm19 liu-hm19 requested a review from SparkYuan July 11, 2024 09:58
@liu-hm19 liu-hm19 self-assigned this Jul 11, 2024
@coveralls
Copy link

coveralls commented Jul 11, 2024

Pull Request Test Coverage Report for Build 9890891103

Details

  • 18 of 31 (58.06%) changed or added relevant lines in 1 file are covered.
  • 7 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.04%) to 54.187%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/util/diff/diff.go 18 31 58.06%
Files with Coverage Reduction New Missed Lines %
pkg/cmd/destroy/destroy.go 7 49.82%
Totals Coverage Status
Change from base Build 9873178919: -0.04%
Covered Lines: 9383
Relevant Lines: 17316

💛 - Coveralls

@liu-hm19 liu-hm19 merged commit dbf3bde into KusionStack:main Jul 18, 2024
8 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jul 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants