Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: locked release file caused by interruption #1219

Merged
merged 2 commits into from
Jul 16, 2024

Conversation

liu-hm19
Copy link
Contributor

What type of PR is this?

/kind bug

What this PR does / why we need it:

This PR fixes the locked release file caused by the command interruption (SIGINT or SIGTERM) when executing kusion destroy.

Which issue(s) this PR fixes:

Fixes #1167

Special notes for your reviewer:

Does this PR introduce a user-facing change?


Additional documentation e.g., design docs, usage docs, etc.:


@liu-hm19 liu-hm19 added the kind/bug Something isn't working label Jul 15, 2024
@liu-hm19 liu-hm19 added this to the v0.12.1 milestone Jul 15, 2024
@liu-hm19 liu-hm19 self-assigned this Jul 15, 2024
@coveralls
Copy link

coveralls commented Jul 15, 2024

Pull Request Test Coverage Report for Build 9936139174

Details

  • 3 of 57 (5.26%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.1%) to 54.078%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/engine/operation/models/change.go 0 7 0.0%
pkg/cmd/destroy/destroy.go 3 50 6.0%
Totals Coverage Status
Change from base Build 9873178919: -0.1%
Covered Lines: 9375
Relevant Lines: 17336

💛 - Coveralls

@adohe adohe merged commit e037960 into KusionStack:main Jul 16, 2024
8 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jul 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: kusion destroy termination leads to a locked release file
4 participants