Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: modularize workload #1236

Merged
merged 1 commit into from
Jul 31, 2024
Merged

Conversation

SparkYuan
Copy link
Member

@SparkYuan SparkYuan commented Jul 29, 2024

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #1098

Special notes for your reviewer:

Does this PR introduce a user-facing change?


Additional documentation e.g., design docs, usage docs, etc.:


@SparkYuan SparkYuan force-pushed the workload-modularize branch 2 times, most recently from 6e0192e to 709ffa9 Compare July 29, 2024 12:54
@coveralls
Copy link

coveralls commented Jul 29, 2024

Pull Request Test Coverage Report for Build 10175558936

Details

  • 63 of 87 (72.41%) changed or added relevant lines in 3 files are covered.
  • 4 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-1.3%) to 52.696%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/oci/reference.go 0 1 0.0%
pkg/modules/generators/secret/secret.go 7 11 63.64%
pkg/modules/generators/app_configurations_generator.go 56 75 74.67%
Files with Coverage Reduction New Missed Lines %
pkg/modules/generators/app_configurations_generator.go 1 68.51%
pkg/engine/operation/parser/parser.go 3 79.27%
Totals Coverage Status
Change from base Build 10173754280: -1.3%
Covered Lines: 8688
Relevant Lines: 16487

💛 - Coveralls

@SparkYuan SparkYuan force-pushed the workload-modularize branch 2 times, most recently from aa5411c to 6dcb3c7 Compare July 31, 2024 04:15
Copy link
Contributor

@liu-hm19 liu-hm19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@liu-hm19 liu-hm19 merged commit f6d89bb into KusionStack:main Jul 31, 2024
8 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jul 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: change workload as a regular module to support customized workloads
3 participants