-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: skip destroy imported resources #1239
Conversation
Pull Request Test Coverage Report for Build 10199276186Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@hoangndst Hi! Sorry for taking some time to review this PR. It looks good to me, but it seems to have conflicts with an updated file from |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
What type of PR is this?
/kind feature
What this PR does / why we need it:
When the imported tf resource is still used by another release, we need to retain it so that the release using that resource can function properly.
Which issue(s) this PR fixes:
Fixes #1200
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., design docs, usage docs, etc.: