Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support kusion state remote storage #124

Merged
merged 1 commit into from
Aug 18, 2022

Conversation

markliby
Copy link
Contributor

@markliby markliby commented Aug 11, 2022

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

re #114

2. What is the scope of this PR (e.g. component or file name):

pkg/engine/backend
pkg/engine/states/local

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other
    support diff backend store state, more detail docs/backend.md

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

6. Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@coveralls
Copy link

coveralls commented Aug 11, 2022

Pull Request Test Coverage Report for Build 2865846997

  • 70 of 107 (65.42%) changed or added relevant lines in 6 files are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.004%) to 74.347%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/kusionctl/cmd/apply/options.go 3 5 60.0%
pkg/kusionctl/cmd/destroy/options.go 8 10 80.0%
pkg/engine/states/local/backend.go 15 20 75.0%
pkg/engine/backend/backend.go 42 70 60.0%
Files with Coverage Reduction New Missed Lines %
pkg/engine/operation/parser/parser.go 3 75.0%
Totals Coverage Status
Change from base Build 2864919723: 0.004%
Covered Lines: 4324
Relevant Lines: 5816

💛 - Coveralls

pkg/engine/backend/init/init.go Outdated Show resolved Hide resolved
pkg/engine/backend/backend.go Outdated Show resolved Hide resolved
pkg/engine/backend/backend.go Outdated Show resolved Hide resolved
pkg/engine/backend/backend.go Outdated Show resolved Hide resolved
pkg/kusionctl/cmd/apply/apply.go Show resolved Hide resolved
pkg/kusionctl/cmd/apply/options.go Outdated Show resolved Hide resolved
@markliby markliby force-pushed the feat_state_backends branch 2 times, most recently from 7263789 to 684e8ae Compare August 12, 2022 06:08
@howieyuen howieyuen added this to the v0.6.0 milestone Aug 12, 2022
Copy link
Collaborator

@howieyuen howieyuen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@howieyuen
Copy link
Collaborator

howieyuen commented Aug 17, 2022

I have a small tip, you can add language in code block in backend.md, like below:
before:

backend:
  storageType: local
  config:
    path: kusion_state.json

after

backend:
  storageType: local
  config:
    path: kusion_state.json

Copy link
Member

@SparkYuan SparkYuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@SparkYuan SparkYuan merged commit 9d20341 into KusionStack:main Aug 18, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Aug 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants