Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: optimize terminal ui for kusion apply #1241

Merged
merged 1 commit into from
Jul 30, 2024

Conversation

liu-hm19
Copy link
Contributor

What type of PR is this?

/kind feature

What this PR does / why we need it:

This PR optimizes the terminal UI for kusion apply.

Which issue(s) this PR fixes:

Fixes #1170

Special notes for your reviewer:

Does this PR introduce a user-facing change?


Additional documentation e.g., design docs, usage docs, etc.:


@liu-hm19 liu-hm19 requested a review from SparkYuan July 30, 2024 08:02
@liu-hm19 liu-hm19 self-assigned this Jul 30, 2024
@liu-hm19 liu-hm19 marked this pull request as ready for review July 30, 2024 08:07
@coveralls
Copy link

Pull Request Test Coverage Report for Build 10158490928

Details

  • 6 of 14 (42.86%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 54.067%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/cmd/apply/apply.go 6 14 42.86%
Totals Coverage Status
Change from base Build 10109208136: 0.02%
Covered Lines: 9399
Relevant Lines: 17384

💛 - Coveralls

Copy link
Member

@SparkYuan SparkYuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@SparkYuan SparkYuan merged commit 2c24840 into KusionStack:main Jul 30, 2024
8 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jul 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feat: optimize the display interface of kusion apply
3 participants