Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: deep copy release to update when destroy #1252

Merged
merged 1 commit into from
Aug 5, 2024

Conversation

liu-hm19
Copy link
Contributor

@liu-hm19 liu-hm19 commented Aug 5, 2024

What type of PR is this?

/kind bug

What this PR does / why we need it:

This PR uses copier.Copy to deeply copy the Release to be updated in kusion destroy command.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?


Additional documentation e.g., design docs, usage docs, etc.:


@liu-hm19 liu-hm19 added the kind/bug Something isn't working label Aug 5, 2024
@liu-hm19 liu-hm19 requested a review from elliotxx August 5, 2024 09:00
@liu-hm19 liu-hm19 self-assigned this Aug 5, 2024
@coveralls
Copy link

Pull Request Test Coverage Report for Build 10245807184

Details

  • 0 of 3 (0.0%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.009%) to 52.623%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/cmd/destroy/destroy.go 0 3 0.0%
Files with Coverage Reduction New Missed Lines %
pkg/engine/operation/watch.go 1 82.76%
Totals Coverage Status
Change from base Build 10200920372: -0.009%
Covered Lines: 8708
Relevant Lines: 16548

💛 - Coveralls

@liu-hm19 liu-hm19 merged commit 8638bc3 into KusionStack:main Aug 5, 2024
8 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Aug 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants