Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support multiple remote state #130

Merged

Conversation

markliby
Copy link
Contributor

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

2. What is the scope of this PR (e.g. component or file name):

pkg/engine/states/remote/db
pkg/engine/states/remote/oss
pkg/engine/states/remote/s3
pkg/engine/states/remote/http

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

kusion supports storage types such as s3 and oss, and users can define the storage state in different remote storages

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

6. Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@coveralls
Copy link

coveralls commented Aug 22, 2022

Pull Request Test Coverage Report for Build 3102693807

  • 135 of 198 (68.18%) changed or added relevant lines in 6 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.1%) to 74.267%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/engine/states/remote/oss/oss_state.go 5 6 83.33%
pkg/engine/states/remote/s3/s3_state.go 9 10 90.0%
pkg/engine/states/remote/db/db_backend.go 31 46 67.39%
pkg/engine/states/remote/oss/oss_backend.go 25 40 62.5%
pkg/engine/states/remote/s3/s3_backend.go 34 49 69.39%
pkg/engine/states/remote/http/http_backend.go 31 47 65.96%
Totals Coverage Status
Change from base Build 3043377590: -0.1%
Covered Lines: 4433
Relevant Lines: 5969

💛 - Coveralls

@markliby markliby force-pushed the feat_support_multi_remote_backend branch from 2fe684e to 34a6fa1 Compare August 22, 2022 03:10
@markliby markliby force-pushed the feat_support_multi_remote_backend branch from 34a6fa1 to 2fd0d17 Compare September 22, 2022 03:44
Copy link
Member

@SparkYuan SparkYuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@elliotxx elliotxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@SparkYuan SparkYuan merged commit c00d812 into KusionStack:main Sep 26, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Sep 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants