Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: kusion apply support ServerSide preview #132

Merged
merged 1 commit into from
Aug 31, 2022

Conversation

howieyuen
Copy link
Collaborator

@howieyuen howieyuen commented Aug 26, 2022

fix: #133

Kusion will try ServerSideDryRun first, if runtime doest not support ServerSideDryRun, kusion will fall back to ClientSideDryRun, user will not perceive it.

@coveralls
Copy link

coveralls commented Aug 26, 2022

Pull Request Test Coverage Report for Build 2933119620

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 14 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.2%) to 74.055%

Files with Coverage Reduction New Missed Lines %
pkg/engine/operation/parser/parser.go 3 75.0%
pkg/engine/operation/parser/spec_parser.go 4 66.04%
pkg/kusionctl/cmd/apply/options.go 7 84.17%
Totals Coverage Status
Change from base Build 2902029216: -0.2%
Covered Lines: 4310
Relevant Lines: 5820

💛 - Coveralls

@howieyuen howieyuen added this to the v0.7.0 milestone Aug 26, 2022
Copy link
Member

@SparkYuan SparkYuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@markliby markliby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@howieyuen howieyuen merged commit c5eea56 into KusionStack:main Aug 31, 2022
@howieyuen howieyuen deleted the server-side-preview branch August 31, 2022 06:29
@github-actions github-actions bot locked and limited conversation to collaborators Aug 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

kusion preview k8s resources from ServerSide aspect
4 participants