Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: appconfig and module generators #1333

Merged
merged 1 commit into from
Dec 2, 2024

Conversation

liu-hm19
Copy link
Contributor

@liu-hm19 liu-hm19 commented Nov 29, 2024

What type of PR is this?

/kind feature

What this PR does / why we need it:

This PR refactors the implementations for generating the Spec of AppConfiguration and the call of Kusion Module.

Which issue(s) this PR fixes:

Fixes #1330

Special notes for your reviewer:

Does this PR introduce a user-facing change?


Additional documentation e.g., design docs, usage docs, etc.:


@liu-hm19 liu-hm19 added the kind/optimization Code optimization label Nov 29, 2024
@liu-hm19 liu-hm19 added this to the v0.14.0 milestone Nov 29, 2024
@liu-hm19 liu-hm19 self-assigned this Nov 29, 2024
@coveralls
Copy link

Pull Request Test Coverage Report for Build 12082624304

Details

  • 97 of 132 (73.48%) changed or added relevant lines in 6 files are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.4%) to 49.074%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/generators/secret/secret.go 3 5 60.0%
pkg/generators/util.go 45 54 83.33%
pkg/generators/orderedresources/ordered_resources_generator.go 21 31 67.74%
pkg/generators/namespace/namespace_generator.go 13 27 48.15%
Files with Coverage Reduction New Missed Lines %
pkg/engine/operation/parser/parser.go 3 79.27%
Totals Coverage Status
Change from base Build 12065653611: 0.4%
Covered Lines: 10445
Relevant Lines: 21284

💛 - Coveralls

Copy link
Contributor

@Yangyang96 Yangyang96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@liu-hm19 liu-hm19 merged commit 7b361d5 into KusionStack:main Dec 2, 2024
14 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/optimization Code optimization
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Modify the way Kusion references the Module's interface and protobuf with SDK
3 participants