Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add kusion mod login and pull sub-command #1345

Merged
merged 3 commits into from
Dec 24, 2024

Conversation

liu-hm19
Copy link
Contributor

@liu-hm19 liu-hm19 commented Dec 17, 2024

What type of PR is this?

/kind feature

What this PR does / why we need it:

This PR implements the kusion mod login and kusion mod pull sub-command for Kusion CLI to login and pull kusion modules declared in kcl.mod file from a private oci registry.

Which issue(s) this PR fixes:

Fixes #1255

Special notes for your reviewer:

Does this PR introduce a user-facing change?


Additional documentation e.g., design docs, usage docs, etc.:


@liu-hm19 liu-hm19 added the kind/feature Categorizes issue or PR as related to a new feature label Dec 17, 2024
@liu-hm19 liu-hm19 self-assigned this Dec 17, 2024
@liu-hm19 liu-hm19 added this to the v0.14.0 milestone Dec 17, 2024
@liu-hm19 liu-hm19 changed the title feat: add kusion mod pull sub-command feat: add kusion mod login and pull sub-command Dec 24, 2024
@coveralls
Copy link

coveralls commented Dec 24, 2024

Pull Request Test Coverage Report for Build 12478820744

Details

  • 0 of 161 (0.0%) changed or added relevant lines in 5 files are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.4%) to 47.988%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/cmd/mod/mod.go 0 2 0.0%
pkg/cmd/generate/generate.go 0 5 0.0%
pkg/engine/api/generate/run/run.go 0 5 0.0%
pkg/cmd/mod/login.go 0 65 0.0%
pkg/cmd/mod/pull.go 0 84 0.0%
Files with Coverage Reduction New Missed Lines %
pkg/engine/operation/parser/parser.go 3 79.27%
Totals Coverage Status
Change from base Build 12476129308: -0.4%
Covered Lines: 10542
Relevant Lines: 21968

💛 - Coveralls

@ffforest ffforest merged commit 422b267 into KusionStack:main Dec 24, 2024
8 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 24, 2024
@ffforest ffforest linked an issue Dec 25, 2024 that may be closed by this pull request
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/feature Categorizes issue or PR as related to a new feature
Projects
None yet
3 participants