Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: cmd preview and apply support new flag '--ignore-fields' #138

Merged
merged 5 commits into from
Sep 13, 2022
Merged

feat: cmd preview and apply support new flag '--ignore-fields' #138

merged 5 commits into from
Sep 13, 2022

Conversation

howieyuen
Copy link
Collaborator

@howieyuen howieyuen commented Sep 5, 2022 •
edited

close: #126

  • feat: cmd preview and apply support new flag '--ignore-fields'
  • refactor: distinguish compile flags and options
  • refactor: move preview logic from cmd/apply to cmd/preview
  • refactor: delete io.writer from func Preview() and add to func Summary()

@howieyuen howieyuen added kind/feature Categorizes issue or PR as related to a new feature cli labels Sep 5, 2022
@howieyuen howieyuen added this to the v0.7.0 milestone Sep 5, 2022
@howieyuen howieyuen linked an issue Sep 5, 2022 that may be closed by this pull request
kusion preview provide a new flag --ignore to support dismiss specified field changes #126
Closed
@coveralls
Copy link

coveralls commented Sep 5, 2022 •
edited

Pull Request Test Coverage Report for Build 2999820496

  • 106 of 122 (86.89%) changed or added relevant lines in 9 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.2%) to 74.403%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/kusionctl/cmd/compile/options.go 6 7 85.71%
pkg/kusionctl/cmd/preview/options.go 62 77 80.52%
Totals Coverage Status
Change from base Build 2997245765: 0.2%
Covered Lines: 4395
Relevant Lines: 5907
💛 - Coveralls

@howieyuen howieyuen force-pushed the ignore-fields branch 2 times, most recently from 8cb1a59 to 393a057 Compare September 5, 2022 09:14
@howieyuen howieyuen force-pushed the ignore-fields branch 3 times, most recently from a981201 to d8c0b3e Compare September 5, 2022 10:35
@howieyuen howieyuen self-assigned this Sep 5, 2022
@SparkYuan
Copy link
Member

Any instructions about this feature？

@howieyuen
Copy link
Collaborator Author

howieyuen commented Sep 13, 2022 •
edited

Any instructions about this feature？

execute kusion preview -h, there is a show case, like below:

# Preview with ignored fields
kusion preview --ignore-fields="metadata.generation,metadata.managedFields"

also see here: https://kusionstack.io/docs/reference/cli/kusionctl/preview/

SparkYuan
SparkYuan approved these changes Sep 13, 2022
View reviewed changes
Copy link
Member

@SparkYuan SparkYuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@SparkYuan SparkYuan enabled auto-merge (squash) September 13, 2022 08:05
markliby
markliby approved these changes Sep 13, 2022
View reviewed changes
Copy link
Contributor

@markliby markliby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@SparkYuan SparkYuan merged commit 91a54c4 into KusionStack:main Sep 13, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Sep 13, 2022
@howieyuen howieyuen deleted the ignore-fields branch September 13, 2022 08:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@SparkYuan SparkYuan SparkYuan approved these changes

@markliby markliby markliby approved these changes

@elliotxx elliotxx Awaiting requested review from elliotxx

Assignees

@howieyuen howieyuen

Labels
kind/feature Categorizes issue or PR as related to a new feature
Projects
None yet
Milestone
v0.7.0
Development

Successfully merging this pull request may close these issues.

kusion preview provide a new flag --ignore to support dismiss specified field changes
4 participants
@howieyuen @coveralls @SparkYuan @markliby