Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: warn when kusion is out of date #157

Merged
merged 1 commit into from
Nov 10, 2022
Merged

feat: warn when kusion is out of date #157

merged 1 commit into from
Nov 10, 2022

Conversation

howieyuen
Copy link
Collaborator

@howieyuen howieyuen commented Nov 7, 2022 •
edited

related issue: #21

process:

  1. read latest version from cache file: .cached_version
  2. fetch latest tag from kusion repo
  3. cache latest version into cache file, expired if over 24h
  4. compare current and latest, decide whether print a warning message.
  5. user can disable version upgrade by setting env KUSION_SKIP_UPDATE_CHECK=true

preview:

image

@howieyuen howieyuen enabled auto-merge (squash) November 7, 2022 12:13
@coveralls
Copy link

coveralls commented Nov 7, 2022 •
edited

Pull Request Test Coverage Report for Build 3410325627

  • 12 of 141 (8.51%) changed or added relevant lines in 2 files are covered.
  • 10 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-1.6%) to 72.145%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/util/kfile/file.go 0 6 0.0%
pkg/kusionctl/cmd/cmd.go 12 135 8.89%
Files with Coverage Reduction New Missed Lines %
pkg/engine/operation/parser/parser.go 3 75.0%
pkg/kusionctl/cmd/destroy/options.go 7 83.25%
Totals Coverage Status
Change from base Build 3407214914: -1.6%
Covered Lines: 4543
Relevant Lines: 6297
💛 - Coveralls

@howieyuen howieyuen added kind/feature Categorizes issue or PR as related to a new feature cli labels Nov 9, 2022
SparkYuan
SparkYuan approved these changes Nov 10, 2022
View reviewed changes
Copy link
Member

@SparkYuan SparkYuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

markliby
markliby approved these changes Nov 10, 2022
View reviewed changes
Copy link
Contributor

@markliby markliby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@howieyuen howieyuen merged commit 8ae079e into KusionStack:main Nov 10, 2022
@howieyuen howieyuen deleted the upgrade-hint branch November 10, 2022 12:48
@github-actions github-actions bot locked and limited conversation to collaborators Nov 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@SparkYuan SparkYuan SparkYuan approved these changes

@markliby markliby markliby approved these changes

Assignees
No one assigned
Labels
kind/feature Categorizes issue or PR as related to a new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@howieyuen @coveralls @SparkYuan @markliby