Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clean code: go fmt pkg/version/types.go #164

Merged
merged 1 commit into from
Nov 10, 2022
Merged

clean code: go fmt pkg/version/types.go #164

merged 1 commit into from
Nov 10, 2022

Conversation

howieyuen
Copy link
Collaborator

No description provided.

@howieyuen howieyuen enabled auto-merge (squash) November 10, 2022 08:54
@coveralls
Copy link

Pull Request Test Coverage Report for Build 3435315705

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 7 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.08%) to 73.707%
Files with Coverage Reduction New Missed Lines %
pkg/engine/operation/parser/parser.go 3 75.0%
pkg/engine/operation/parser/spec_parser.go 4 66.04%
Totals Coverage Status
Change from base Build 3435117748: -0.08%
Covered Lines: 4547
Relevant Lines: 6169
💛 - Coveralls

markliby
markliby approved these changes Nov 10, 2022
View reviewed changes
Copy link
Contributor

@markliby markliby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@howieyuen howieyuen merged commit c2d9ca3 into KusionStack:main Nov 10, 2022
@howieyuen howieyuen deleted the cleancode branch November 10, 2022 11:39
@github-actions github-actions bot locked and limited conversation to collaborators Nov 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@SparkYuan SparkYuan SparkYuan approved these changes

@markliby markliby markliby approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@howieyuen @coveralls @SparkYuan @markliby