Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: refactor compile flags #165

Merged
merged 1 commit into from
Nov 14, 2022
Merged

chore: refactor compile flags #165

merged 1 commit into from
Nov 14, 2022

Conversation

howieyuen
Copy link
Collaborator

@howieyuen howieyuen commented Nov 14, 2022 •
edited

  1. move --no-style flag from ApplyOptions to PreviewOptions
  2. default preview result is summary, --detail can output details

image

@howieyuen howieyuen enabled auto-merge (squash) November 14, 2022 06:22
@coveralls
Copy link

Pull Request Test Coverage Report for Build 3459159455

  • 4 of 7 (57.14%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.2%) to 72.338%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/kusionctl/cmd/preview/options.go 2 5 40.0%
Totals Coverage Status
Change from base Build 3436930342: 0.2%
Covered Lines: 4566
Relevant Lines: 6312
💛 - Coveralls

markliby
markliby approved these changes Nov 14, 2022
View reviewed changes
Copy link
Contributor

@markliby markliby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

elliotxx
elliotxx approved these changes Nov 14, 2022
View reviewed changes
Copy link
Contributor

@elliotxx elliotxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@howieyuen howieyuen merged commit 7328658 into KusionStack:main Nov 14, 2022
@howieyuen howieyuen deleted the preview-flag branch November 14, 2022 07:15
@github-actions github-actions bot locked and limited conversation to collaborators Nov 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@elliotxx elliotxx elliotxx approved these changes

@markliby markliby markliby approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@howieyuen @coveralls @elliotxx @markliby