Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add note to skip version upgrade check #175

Merged
merged 1 commit into from
Nov 22, 2022
Merged

chore: add note to skip version upgrade check #175

merged 1 commit into from
Nov 22, 2022

Conversation

howieyuen
Copy link
Collaborator

@howieyuen howieyuen commented Nov 22, 2022 •
edited

thanks to @Peefy for this delightful tip

@howieyuen howieyuen enabled auto-merge (squash) November 22, 2022 08:13
markliby
markliby approved these changes Nov 22, 2022
View reviewed changes
Copy link
Contributor

@markliby markliby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@coveralls
Copy link

Pull Request Test Coverage Report for Build 3521529198

  • 0 of 2 (0.0%) changed or added relevant lines in 1 file are covered.
  • 11 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.1%) to 72.228%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/kusionctl/cmd/cmd.go 0 2 0.0%
Files with Coverage Reduction New Missed Lines %
pkg/kusionctl/cmd/cmd.go 1 35.5%
pkg/engine/operation/parser/spec_parser.go 4 66.04%
pkg/engine/operation/parser/parser.go 6 70.0%
Totals Coverage Status
Change from base Build 3514670323: -0.1%
Covered Lines: 4559
Relevant Lines: 6312
💛 - Coveralls

@howieyuen howieyuen requested review from Peefy and removed request for SparkYuan November 22, 2022 08:24
Peefy
Peefy approved these changes Nov 22, 2022
View reviewed changes
Copy link
Contributor

@Peefy Peefy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@howieyuen howieyuen merged commit 86d11d6 into KusionStack:main Nov 22, 2022
@howieyuen howieyuen deleted the skip-version-check branch November 22, 2022 08:27
@github-actions github-actions bot locked and limited conversation to collaborators Nov 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Peefy Peefy Peefy approved these changes

@markliby markliby markliby approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@howieyuen @coveralls @Peefy @markliby