Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: watch dependents and print them with new console UI #176

Merged
merged 1 commit into from
Nov 28, 2022

Conversation

howieyuen
Copy link
Collaborator

@howieyuen howieyuen commented Nov 22, 2022

close: #167

main changes:

  1. relationships among resources, including ownerRef and selector
  2. structured watch data, not flush screen with new message
  3. table like UI, print each resource as table and render dynamically

sample:

imageonline-gifspeed-4243603

@howieyuen howieyuen enabled auto-merge (squash) November 22, 2022 09:32
@howieyuen howieyuen added kind/feature Categorizes issue or PR as related to a new feature area/cli labels Nov 22, 2022
@coveralls
Copy link

coveralls commented Nov 22, 2022

Pull Request Test Coverage Report for Build 3530906873

  • 48 of 54 (88.89%) changed or added relevant lines in 1 file are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.6%) to 72.759%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/engine/operation/watch.go 48 54 88.89%
Files with Coverage Reduction New Missed Lines %
pkg/engine/operation/watch.go 2 87.36%
Totals Coverage Status
Change from base Build 3523382780: 0.6%
Covered Lines: 4562
Relevant Lines: 6270

💛 - Coveralls

@howieyuen howieyuen merged commit 9e15717 into KusionStack:main Nov 28, 2022
@howieyuen howieyuen deleted the watch-ui branch November 28, 2022 02:35
@github-actions github-actions bot locked and limited conversation to collaborators Nov 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/feature Categorizes issue or PR as related to a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Kusion watch not only resource itself but also dependents
4 participants