Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: empty resources in stack will generate panic #177

Merged
merged 4 commits into from
Nov 28, 2022

Conversation

SparkYuan
Copy link
Member

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

2. What is the scope of this PR (e.g. component or file name):

apply and preview cmd

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

6. Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

support empty resource in stack in some circumstances

@SparkYuan SparkYuan enabled auto-merge (squash) November 24, 2022 08:01
@coveralls
Copy link

Pull Request Test Coverage Report for Build 3545812374

  • 2 of 8 (25.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 72.326%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/kusionctl/cmd/apply/options.go 1 4 25.0%
pkg/kusionctl/cmd/preview/options.go 1 4 25.0%
Totals Coverage Status
Change from base Build 3523382780: 0.1%
Covered Lines: 4571
Relevant Lines: 6320

💛 - Coveralls

@SparkYuan SparkYuan added this to the v0.8 milestone Nov 26, 2022
@SparkYuan SparkYuan added the kind/bug Something isn't working label Nov 26, 2022
@SparkYuan SparkYuan merged commit b4b215b into KusionStack:main Nov 28, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Nov 28, 2022
@SparkYuan SparkYuan deleted the fix-empty-resources branch June 26, 2023 07:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants