Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: refactor preview flags #180

Merged
merged 1 commit into from
Nov 29, 2022
Merged

chore: refactor preview flags #180

merged 1 commit into from
Nov 29, 2022

Conversation

howieyuen
Copy link
Collaborator

  1. kusion preview: add new flag --all, combined with --detail, will directly print all diff details without interaction.
  2. kusion apply: remove useless flag OnlyPreview, which is never used.
  3. refactor func CompileWithSpinner(), make spinner style can be turn on/off by --no-style

@howieyuen howieyuen enabled auto-merge (squash) November 28, 2022 03:01
@coveralls
Copy link

coveralls commented Nov 28, 2022 •
edited

Pull Request Test Coverage Report for Build 3570735634

  • 45 of 76 (59.21%) changed or added relevant lines in 5 files are covered.
  • 8 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.2%) to 72.584%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/kusionctl/cmd/apply/options.go 23 29 79.31%
pkg/compile/compile.go 0 25 0.0%
Files with Coverage Reduction New Missed Lines %
pkg/compile/compile.go 1 67.38%
pkg/kusionctl/cmd/apply/options.go 7 73.71%
Totals Coverage Status
Change from base Build 3561398958: 0.2%
Covered Lines: 4575
Relevant Lines: 6303
💛 - Coveralls

elliotxx
elliotxx previously approved these changes Nov 29, 2022
View reviewed changes
Copy link
Contributor

@elliotxx elliotxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

markliby
markliby approved these changes Nov 29, 2022
View reviewed changes
Copy link
Contributor

@markliby markliby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@howieyuen howieyuen merged commit 12b110d into KusionStack:main Nov 29, 2022
@howieyuen howieyuen deleted the refactor-flags branch November 29, 2022 03:47
@github-actions github-actions bot locked and limited conversation to collaborators Nov 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@elliotxx elliotxx elliotxx approved these changes

@markliby markliby markliby approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@howieyuen @coveralls @elliotxx @markliby