Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kusion watch: filter out unchanged resources #181

Merged
merged 1 commit into from
Nov 29, 2022
Merged

kusion watch: filter out unchanged resources #181

merged 1 commit into from
Nov 29, 2022

Conversation

howieyuen
Copy link
Collaborator

No description provided.

@howieyuen howieyuen enabled auto-merge (squash) November 28, 2022 12:14
@coveralls
Copy link

coveralls commented Nov 28, 2022 •
edited

Pull Request Test Coverage Report for Build 3570864603

  • 0 of 9 (0.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 72.403%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/kusionctl/cmd/apply/options.go 0 9 0.0%
Totals Coverage Status
Change from base Build 3570831183: 0%
Covered Lines: 4565
Relevant Lines: 6305
💛 - Coveralls

markliby
markliby previously approved these changes Nov 29, 2022
View reviewed changes
SparkYuan
SparkYuan previously approved these changes Nov 29, 2022
View reviewed changes
Copy link
Member

@SparkYuan SparkYuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@howieyuen howieyuen dismissed stale reviews from SparkYuan and markliby via 767ba7f November 29, 2022 03:53
@howieyuen howieyuen force-pushed the filter-unchanged branch 2 times, most recently from 767ba7f to 3b63fe8 Compare November 29, 2022 03:54
SparkYuan
SparkYuan approved these changes Nov 29, 2022
View reviewed changes
Copy link
Member

@SparkYuan SparkYuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@howieyuen howieyuen merged commit 4ef46f7 into KusionStack:main Nov 29, 2022
@howieyuen howieyuen deleted the filter-unchanged branch November 29, 2022 06:20
@github-actions github-actions bot locked and limited conversation to collaborators Nov 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@SparkYuan SparkYuan SparkYuan approved these changes

@markliby markliby markliby approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@howieyuen @coveralls @SparkYuan @markliby