Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: differentiate dry run action based on live state is nil or not #187

Merged
merged 1 commit into from
Dec 5, 2022

Conversation

howieyuen
Copy link
Collaborator

@howieyuen howieyuen commented Dec 5, 2022

kusion will try ServerSideDryRun first, and fall back to ClientSideDryRun if runtime is not supported.

But, forget to distinguish live state is nil or not, so jsonpatch.MergePatch() return a nil pointer.

@howieyuen howieyuen enabled auto-merge (squash) December 5, 2022 12:13
@coveralls
Copy link

Pull Request Test Coverage Report for Build 3619910019

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.02%) to 72.407%

Files with Coverage Reduction New Missed Lines %
pkg/engine/operation/parser/parser.go 3 75.0%
Totals Coverage Status
Change from base Build 3589366913: -0.02%
Covered Lines: 4566
Relevant Lines: 6306

💛 - Coveralls

@howieyuen howieyuen self-assigned this Dec 5, 2022
@howieyuen howieyuen added kind/bug Something isn't working area/runtime labels Dec 5, 2022
Copy link
Member

@SparkYuan SparkYuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@howieyuen howieyuen merged commit 6bb5eed into main Dec 5, 2022
@howieyuen howieyuen deleted the live-state-is-nil branch December 5, 2022 13:01
@github-actions github-actions bot locked and limited conversation to collaborators Dec 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants