Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

delete the replace domain in go.mod for go install #189

Merged
merged 3 commits into from
Dec 12, 2022

Conversation

SparkYuan
Copy link
Member

@SparkYuan SparkYuan commented Dec 6, 2022

Package terraform contains codes about "terraform/dag" and "terraform/tfdiags" copied from Terraform.

Terraform is an open-source project but makes almost all codes in an internal package. It's not a friendly way to benefit the open-source community.
The latest non-internal Terraform version is v0.15.3, but the k8s related modules in it are less than v1.15. That is too old for us
and is incompatible with our existing modules.

We import terraform/dag to reuse its DAG structure, and we will build our own DAG structure to support more complex Kusion workflow later.
We import terraform/tfdiags because terraform/dag imported this module, this module will be deleted together when we replace the DAG
structure with our own.

I update go version to 1.18 because of generics are used in TF's codes

@SparkYuan SparkYuan enabled auto-merge (squash) December 6, 2022 13:33
@SparkYuan SparkYuan force-pushed the tidy-mod branch 2 times, most recently from 9f75be0 to 35249db Compare December 6, 2022 13:53
@coveralls
Copy link

coveralls commented Dec 6, 2022

Pull Request Test Coverage Report for Build 3656276777

  • 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.4%) to 72.381%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/kusionctl/cmd/cmd.go 0 1 0.0%
Totals Coverage Status
Change from base Build 3645101894: 0.4%
Covered Lines: 4581
Relevant Lines: 6329

💛 - Coveralls

@howieyuen
Copy link
Collaborator

howieyuen commented Dec 7, 2022

directly copy Terraform's source code???

@SparkYuan
Copy link
Member Author

directly copy Terraform's source code???

Yes, because of the limitation of Terraform, currently, we have to reuse some code by copying source code instead of importing by go mod.

We will upgrade our DAG structure and delete these TF related code in Jan 2023

pkg/engine/operation/apply.go Outdated Show resolved Hide resolved
pkg/engine/doc.go Show resolved Hide resolved
pkg/engine/operation/destory.go Outdated Show resolved Hide resolved
pkg/engine/operation/graph/resource_node_test.go Outdated Show resolved Hide resolved
pkg/engine/operation/parser/delete_resource_parser.go Outdated Show resolved Hide resolved
pkg/engine/operation/parser/parser.go Outdated Show resolved Hide resolved
pkg/engine/operation/parser/spec_parser.go Outdated Show resolved Hide resolved
pkg/engine/operation/preview.go Outdated Show resolved Hide resolved
pkg/engine/states/remote/http/http_state.go Show resolved Hide resolved
pkg/util/pretty/prefix_printer.go Show resolved Hide resolved
pkg/util/pretty/prefix_text_printer.go Show resolved Hide resolved
pkg/util/pretty/spinner.go Show resolved Hide resolved
pkg/util/pretty/spinner_text.go Show resolved Hide resolved
pkg/util/pretty/style.go Show resolved Hide resolved
third_party/pulumi/doc.go Outdated Show resolved Hide resolved
@howieyuen
Copy link
Collaborator

please rebase main branch and re-arrange these commits as follows:

  1. replace TF module with 3rd-party
  2. fix uts
  3. upgrade go verison to 1.18, golinter to 1.50+
  4. gofumpt codes

@howieyuen
Copy link
Collaborator

howieyuen commented Dec 9, 2022

delete this file: third_party/pulumi/doc.go

@SparkYuan SparkYuan merged commit b5cb537 into KusionStack:main Dec 12, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Dec 12, 2022
@SparkYuan SparkYuan deleted the tidy-mod branch June 26, 2023 07:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants