Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support vault as secret store #202

Merged
merged 1 commit into from
Feb 2, 2023
Merged

feat: support vault as secret store #202

merged 1 commit into from
Feb 2, 2023

Conversation

howieyuen
Copy link
Collaborator

@howieyuen howieyuen commented Dec 26, 2022 •
edited

related: #149 (comment)

project example: KusionStack/konfig#77

@coveralls
Copy link

coveralls commented Dec 26, 2022 •
edited

Pull Request Test Coverage Report for Build 3935903539

  • 48 of 70 (68.57%) changed or added relevant lines in 6 files are covered.
  • 13 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.2%) to 71.85%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/kusionctl/cmd/apply/options.go 4 6 66.67%
pkg/kusionctl/cmd/preview/options.go 3 5 60.0%
pkg/engine/operation/graph/resource_node.go 38 56 67.86%
Files with Coverage Reduction New Missed Lines %
pkg/engine/operation/graph/resource_node.go 6 58.78%
pkg/kusionctl/cmd/apply/options.go 7 70.08%
Totals Coverage Status
Change from base Build 3926938443: -0.2%
Covered Lines: 4625
Relevant Lines: 6437
💛 - Coveralls

@howieyuen howieyuen added kind/feature Categorizes issue or PR as related to a new feature area/cli labels Jan 4, 2023
@howieyuen howieyuen enabled auto-merge (squash) January 4, 2023 07:06
SparkYuan
SparkYuan reviewed Jan 5, 2023
View reviewed changes
pkg/kusionctl/cmd/apply/options.go Outdated Show resolved Hide resolved
pkg/vals/secret_stores.go Show resolved Hide resolved
markliby
markliby approved these changes Feb 2, 2023
View reviewed changes
Copy link
Contributor

@markliby markliby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@howieyuen howieyuen merged commit a5397fd into KusionStack:main Feb 2, 2023
@howieyuen howieyuen deleted the vals branch February 2, 2023 03:22
@github-actions github-actions bot locked and limited conversation to collaborators Feb 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@SparkYuan SparkYuan SparkYuan left review comments

@markliby markliby markliby approved these changes

Assignees
No one assigned
Labels
kind/feature Categorizes issue or PR as related to a new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@howieyuen @coveralls @SparkYuan @markliby