Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix tf state id #203

Merged
merged 1 commit into from
Dec 28, 2022
Merged

fix tf state id #203

merged 1 commit into from
Dec 28, 2022

Conversation

markliby
Copy link
Contributor

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

2. What is the scope of this PR (e.g. component or file name):

pkg/engine/runtime/terraform/terraform_runtime.go

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

6. Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@coveralls
Copy link

Pull Request Test Coverage Report for Build 3786014623

  • 2 of 4 (50.0%) changed or added relevant lines in 1 file are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.02%) to 72.327%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/engine/runtime/terraform/terraform_runtime.go 2 4 50.0%
Files with Coverage Reduction New Missed Lines %
pkg/engine/operation/parser/parser.go 3 70.0%
Totals Coverage Status
Change from base Build 3784951641: -0.02%
Covered Lines: 4600
Relevant Lines: 6360

💛 - Coveralls

@SparkYuan SparkYuan enabled auto-merge (squash) December 27, 2022 12:08
Copy link
Member

@SparkYuan SparkYuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@SparkYuan SparkYuan merged commit 1b87acb into KusionStack:main Dec 28, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Dec 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants