Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: bump kclvm version and support kclvm windows artifact. #207

Merged
merged 1 commit into from
Jan 3, 2023

Conversation

Peefy
Copy link
Contributor

@Peefy Peefy commented Dec 30, 2022

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

fix: #179

feat: bump kclvm version and support kclvm windows artifact.

2. What is the scope of this PR (e.g. component or file name):

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

6. Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@Peefy Peefy added the release label Dec 30, 2022
@Peefy Peefy self-assigned this Dec 30, 2022
@Peefy Peefy force-pushed the feat-kclvm-windows-artifact branch from bc1c90a to 9d1c5cb Compare December 30, 2022 07:10
Makefile Outdated Show resolved Hide resolved
@coveralls
Copy link

coveralls commented Dec 30, 2022

Pull Request Test Coverage Report for Build 3805444309

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.09%) to 72.446%

Files with Coverage Reduction New Missed Lines %
pkg/engine/operation/parser/parser.go 3 75.0%
Totals Coverage Status
Change from base Build 3792925804: 0.09%
Covered Lines: 4609
Relevant Lines: 6362

💛 - Coveralls

@Peefy Peefy force-pushed the feat-kclvm-windows-artifact branch from 9d1c5cb to 08064a0 Compare December 30, 2022 07:17
@howieyuen howieyuen enabled auto-merge (squash) December 30, 2022 07:28
Copy link
Contributor

@chai2010 chai2010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@howieyuen howieyuen merged commit 6949059 into KusionStack:main Jan 3, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jan 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invalid triple: "windows" ([Darwin ubuntu centos Darwin-arm64])
4 participants