Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update makefile #211

Merged
merged 1 commit into from
Jan 4, 2023
Merged

update makefile #211

merged 1 commit into from
Jan 4, 2023

Conversation

howieyuen
Copy link
Collaborator

@howieyuen howieyuen commented Jan 3, 2023 •
edited

  • there is no distinction between centos and ubuntu for kclvm
  • no need to install kcl-go or kclvm once again, cause they are embebed in kclvm-go
  • embeded kcl stuff will save in GOBIN

@howieyuen howieyuen enabled auto-merge (squash) January 3, 2023 12:50
@coveralls
Copy link

coveralls commented Jan 3, 2023 •
edited

Pull Request Test Coverage Report for Build 3835853697

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.1%) to 72.35%
Files with Coverage Reduction New Missed Lines %
pkg/engine/operation/parser/parser.go 3 75.0%
Totals Coverage Status
Change from base Build 3828804367: -0.1%
Covered Lines: 4587
Relevant Lines: 6340
💛 - Coveralls

Peefy
Peefy reviewed Jan 3, 2023
View reviewed changes
Makefile Show resolved Hide resolved
@howieyuen howieyuen force-pushed the makefile branch 7 times, most recently from 0c335f1 to 524da14 Compare January 4, 2023 06:45
@howieyuen
fix makefile
c2fa1e5 
- kclvm is no distinction between centos and ubuntu
- no need to install kcl-go or kclvm anymore, cause they are embebed in kclvm-go
Peefy
Peefy approved these changes Jan 4, 2023
View reviewed changes
Copy link
Contributor

@Peefy Peefy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@howieyuen howieyuen merged commit 06b83fa into KusionStack:main Jan 4, 2023
@howieyuen howieyuen deleted the makefile branch January 4, 2023 07:24
@github-actions github-actions bot locked and limited conversation to collaborators Jan 4, 2023
@howieyuen howieyuen changed the title fix makefile update makefile Jan 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Peefy Peefy Peefy approved these changes

@markliby markliby markliby approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@howieyuen @coveralls @Peefy @markliby