Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix kusion compile terminal output #212

Merged

Conversation

markliby
Copy link
Contributor

@markliby markliby commented Jan 5, 2023

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

2. What is the scope of this PR (e.g. component or file name):

pkg/kusionctl/cmd/compile/options.go

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

fix kusion compile terminal output,when run kusion compile -o stdout, kusion compile result output in terminal.

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

6. Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

howieyuen
howieyuen previously approved these changes Jan 5, 2023
@howieyuen howieyuen self-requested a review January 5, 2023 10:05
@markliby markliby force-pushed the fix_kusion_compile_terminal_output branch from 910728a to fc713f0 Compare January 5, 2023 12:04
@markliby markliby changed the title fix kusion compile termainal output fix kusion compile terminal output Jan 5, 2023
@coveralls
Copy link

coveralls commented Jan 5, 2023

Pull Request Test Coverage Report for Build 3853319393

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • 6 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.05%) to 72.177%

Files with Coverage Reduction New Missed Lines %
pkg/kusionctl/cmd/compile/options.go 6 62.3%
Totals Coverage Status
Change from base Build 3853275339: 0.05%
Covered Lines: 4602
Relevant Lines: 6376

💛 - Coveralls

@howieyuen howieyuen enabled auto-merge (squash) January 6, 2023 06:45
@markliby markliby force-pushed the fix_kusion_compile_terminal_output branch from fc713f0 to ec66e3e Compare January 6, 2023 06:59
@howieyuen howieyuen merged commit 5fa7704 into KusionStack:main Jan 6, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jan 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants