Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

style: "io/ioutil" has been deprecated since Go 1.16 #217

Merged
merged 1 commit into from
Jan 9, 2023
Merged

style: "io/ioutil" has been deprecated since Go 1.16 #217

merged 1 commit into from
Jan 9, 2023

Conversation

ismdeep
Copy link
Contributor

@ismdeep ismdeep commented Jan 9, 2023

No description provided.

@github-actions
Copy link

github-actions bot commented Jan 9, 2023 •
edited

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@ismdeep
Copy link
Contributor Author

ismdeep commented Jan 9, 2023

I have read the CLA Document and I hereby sign the CLA

@howieyuen howieyuen enabled auto-merge (squash) January 9, 2023 06:23
@coveralls
Copy link

Pull Request Test Coverage Report for Build 3871085824

  • 14 of 16 (87.5%) changed or added relevant lines in 8 files are covered.
  • 14 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.1%) to 72.014%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/scaffold/templates.go 5 6 83.33%
pkg/util/kfile/file.go 1 2 50.0%
Files with Coverage Reduction New Missed Lines %
pkg/engine/operation/parser/parser.go 3 75.0%
pkg/engine/operation/parser/spec_parser.go 4 66.04%
pkg/kusionctl/cmd/apply/options.go 7 70.27%
Totals Coverage Status
Change from base Build 3870330938: -0.1%
Covered Lines: 4601
Relevant Lines: 6389
💛 - Coveralls

howieyuen
howieyuen approved these changes Jan 9, 2023
View reviewed changes
Copy link
Collaborator

@howieyuen howieyuen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to KusionStack! Thanks for your contribution!

@howieyuen howieyuen merged commit 37fb45d into KusionStack:main Jan 9, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jan 9, 2023
@howieyuen howieyuen added the kind/optimization Code optimization label Jan 9, 2023
@ismdeep ismdeep deleted the develop/style#fix-deprecated-ioutil branch January 13, 2023 02:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@howieyuen howieyuen howieyuen approved these changes

Assignees
No one assigned
Labels
kind/optimization Code optimization
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ismdeep @coveralls @howieyuen