Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support provider log output #220

Merged

Conversation

markliby
Copy link
Contributor

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

2. What is the scope of this PR (e.g. component or file name):

pkg/engine/runtime/terraform/tfops/workspace.go

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

Support log output to kusion-debug.log when kusion tf runtime provider is executed

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

6. Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@coveralls
Copy link

coveralls commented Jan 10, 2023

Pull Request Test Coverage Report for Build 4042459739

  • 12 of 14 (85.71%) changed or added relevant lines in 1 file are covered.
  • 14 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.1%) to 71.95%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/engine/runtime/terraform/tfops/workspace.go 12 14 85.71%
Files with Coverage Reduction New Missed Lines %
pkg/engine/operation/parser/parser.go 3 75.0%
pkg/engine/operation/parser/spec_parser.go 4 66.04%
pkg/kusionctl/cmd/apply/options.go 7 70.27%
Totals Coverage Status
Change from base Build 4041985259: -0.1%
Covered Lines: 4594
Relevant Lines: 6385

💛 - Coveralls

@markliby markliby force-pushed the feat_support_provider_log_output branch 2 times, most recently from 5a8eff4 to 705160a Compare January 16, 2023 06:28
@markliby markliby force-pushed the feat_support_provider_log_output branch from 705160a to 69a90ae Compare January 30, 2023 09:12
@markliby markliby force-pushed the feat_support_provider_log_output branch from 69a90ae to 1baa125 Compare January 30, 2023 09:34
@howieyuen howieyuen enabled auto-merge (squash) February 2, 2023 03:12
@howieyuen howieyuen merged commit e4db076 into KusionStack:main Feb 2, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Feb 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants