Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

auto import resources exist in spec and live cluster but no recorded in kusion_state.json #222

Merged
merged 1 commit into from
Jan 16, 2023
Merged

auto import resources exist in spec and live cluster but no recorded in kusion_state.json #222

merged 1 commit into from
Jan 16, 2023

Conversation

SparkYuan
Copy link
Member

auto import resources exist in spec and live cluster but no recorded in kusion_state.json

@SparkYuan SparkYuan enabled auto-merge (squash) January 13, 2023 07:58
@coveralls
Copy link

Pull Request Test Coverage Report for Build 3909440078

  • 3 of 10 (30.0%) changed or added relevant lines in 1 file are covered.
  • 7 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.09%) to 72.068%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/engine/operation/graph/resource_node.go 3 10 30.0%
Files with Coverage Reduction New Missed Lines %
pkg/engine/operation/parser/parser.go 3 75.0%
pkg/engine/operation/parser/spec_parser.go 4 66.04%
Totals Coverage Status
Change from base Build 3871334989: -0.09%
Covered Lines: 4608
Relevant Lines: 6394
💛 - Coveralls

markliby
markliby approved these changes Jan 16, 2023
View reviewed changes
Copy link
Contributor

@markliby markliby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@SparkYuan SparkYuan merged commit a8a2767 into KusionStack:main Jan 16, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jan 16, 2023
@SparkYuan SparkYuan deleted the auto-import-resources branch June 26, 2023 07:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@markliby markliby markliby approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@SparkYuan @coveralls @markliby