Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Makefile #226

Merged
merged 1 commit into from
Jan 30, 2023
Merged

Update Makefile #226

merged 1 commit into from
Jan 30, 2023

Conversation

howieyuen
Copy link
Collaborator

No description provided.

@howieyuen howieyuen enabled auto-merge (squash) January 30, 2023 08:03
@howieyuen howieyuen added the kind/bug Something isn't working label Jan 30, 2023
@coveralls
Copy link

Pull Request Test Coverage Report for Build 4041745093

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.02%) to 72.092%
Files with Coverage Reduction New Missed Lines %
pkg/engine/operation/parser/parser.go 3 75.0%
Totals Coverage Status
Change from base Build 4039973763: -0.02%
Covered Lines: 4593
Relevant Lines: 6371
💛 - Coveralls

SparkYuan
SparkYuan approved these changes Jan 30, 2023
View reviewed changes
Copy link
Member

@SparkYuan SparkYuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@howieyuen howieyuen merged commit 62619d7 into main Jan 30, 2023
@howieyuen howieyuen deleted the howieyuen-patch-1 branch January 30, 2023 08:34
@github-actions github-actions bot locked and limited conversation to collaborators Jan 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@SparkYuan SparkYuan SparkYuan approved these changes

@markliby markliby Awaiting requested review from markliby

Assignees
No one assigned
Labels
kind/bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@howieyuen @coveralls @SparkYuan