Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade kcl compilation to spec generator #230

Merged
merged 1 commit into from
Feb 2, 2023

Conversation

SparkYuan
Copy link
Member

This PR proposed a Spec generator mechanism that can make Kusion more general in generating Spec and decoupled with KCLVM. Any generator implements the generator interface can be integrated in Kusion operation workflow.

This mechanism is very meaningful to Kusion and makes the foundation to support other languages in the feature.

@SparkYuan SparkYuan enabled auto-merge (squash) February 1, 2023 12:55
@coveralls
Copy link

coveralls commented Feb 1, 2023

Pull Request Test Coverage Report for Build 4072836859

  • 36 of 62 (58.06%) changed or added relevant lines in 7 files are covered.
  • 6 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.08%) to 72.067%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/kusionctl/cmd/apply/options.go 5 6 83.33%
pkg/kusionctl/generator/kcl/kcl_generator.go 22 23 95.65%
pkg/projectstack/project.go 2 5 40.0%
pkg/kusionctl/cmd/compile/options.go 0 21 0.0%
Files with Coverage Reduction New Missed Lines %
pkg/kusionctl/cmd/compile/options.go 6 34.18%
Totals Coverage Status
Change from base Build 4071024050: 0.08%
Covered Lines: 4626
Relevant Lines: 6419

💛 - Coveralls

pkg/kusionctl/cmd/spec/generator.go Show resolved Hide resolved
pkg/kusionctl/generator/generator.go Show resolved Hide resolved
pkg/kusionctl/generator/models/config.go Outdated Show resolved Hide resolved
pkg/kusionctl/generator/generator.go Outdated Show resolved Hide resolved
pkg/kusionctl/generator/kcl/util.go Outdated Show resolved Hide resolved
@SparkYuan SparkYuan force-pushed the generator-interface branch 3 times, most recently from bbd7109 to 1e819d7 Compare February 2, 2023 05:32
@SparkYuan SparkYuan merged commit ee0d8ca into KusionStack:main Feb 2, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Feb 2, 2023
@SparkYuan SparkYuan added the kind/feature Categorizes issue or PR as related to a new feature label Feb 2, 2023
@SparkYuan SparkYuan deleted the generator-interface branch June 26, 2023 07:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/feature Categorizes issue or PR as related to a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants