Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support scoop install for windows #231

Merged
merged 1 commit into from
Feb 9, 2023
Merged

feat: support scoop install for windows #231

merged 1 commit into from
Feb 9, 2023

Conversation

howieyuen
Copy link
Collaborator

Release scoop package for windows users by goreleaser.

@howieyuen howieyuen enabled auto-merge (squash) February 2, 2023 03:39
@howieyuen howieyuen added ci/release kind/feature Categorizes issue or PR as related to a new feature labels Feb 2, 2023
@coveralls
Copy link

Pull Request Test Coverage Report for Build 4071041002

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 14 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.2%) to 71.804%
Files with Coverage Reduction New Missed Lines %
pkg/engine/operation/parser/parser.go 3 70.0%
pkg/engine/operation/parser/spec_parser.go 4 66.04%
pkg/kusionctl/cmd/apply/options.go 7 71.2%
Totals Coverage Status
Change from base Build 4071024050: -0.2%
Covered Lines: 4612
Relevant Lines: 6423
💛 - Coveralls

SparkYuan
SparkYuan approved these changes Feb 9, 2023
View reviewed changes
Copy link
Member

@SparkYuan SparkYuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@howieyuen howieyuen merged commit 249cd6d into KusionStack:main Feb 9, 2023
@howieyuen howieyuen deleted the scoop branch February 9, 2023 03:08
@github-actions github-actions bot locked and limited conversation to collaborators Feb 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@SparkYuan SparkYuan SparkYuan approved these changes

@markliby markliby Awaiting requested review from markliby

@healthjyk healthjyk Awaiting requested review from healthjyk

Assignees
No one assigned
Labels
kind/feature Categorizes issue or PR as related to a new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@howieyuen @coveralls @SparkYuan