Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Auto import resources exist in spec and live cluster but no recorded in Kusion #236

Merged
merged 3 commits into from
Feb 9, 2023
Merged

Auto import resources exist in spec and live cluster but no recorded in Kusion #236

merged 3 commits into from
Feb 9, 2023

Conversation

SparkYuan
Copy link
Member

@SparkYuan SparkYuan commented Feb 7, 2023 •
edited

What type of PR is this?

What this PR does / why we need it:

/kind feature

Fix issue

#237

Special notes for your reviewer:

  1. Add import in Runtime interface to import different type Runtime separately
  2. move KubernetesRuntime into runtime/kubernetes

Does this PR introduce a user-facing change?

Auto import resources exist in spec and live cluster but no recorded in Kusion

Additional documentation e.g., design docs, usage docs, etc.:

@SparkYuan SparkYuan added kind/feature Categorizes issue or PR as related to a new feature area/runtime labels Feb 7, 2023
@SparkYuan SparkYuan force-pushed the runtime-import branch 3 times, most recently from f19055f to 3cd42b4 Compare February 8, 2023 04:09
@coveralls
Copy link

coveralls commented Feb 8, 2023 •
edited

Pull Request Test Coverage Report for Build 4121544628

  • 4 of 16 (25.0%) changed or added relevant lines in 2 files are covered.
  • 8 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.2%) to 71.81%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/engine/operation/graph/resource_node.go 4 9 44.44%
pkg/engine/runtime/terraform/terraform_runtime.go 0 7 0.0%
Files with Coverage Reduction New Missed Lines %
pkg/engine/runtime/terraform/terraform_runtime.go 1 45.95%
pkg/cmd/apply/options.go 7 71.2%
Totals Coverage Status
Change from base Build 4120285669: -0.2%
Covered Lines: 4621
Relevant Lines: 6435
💛 - Coveralls

@SparkYuan SparkYuan changed the title Auto import resources exist in spec and live cluster but no recorded in kusion_state.json Auto import resources exist in spec and live cluster but no recorded in Kusion Feb 8, 2023
@SparkYuan SparkYuan enabled auto-merge (squash) February 8, 2023 06:36
markliby
markliby approved these changes Feb 9, 2023
View reviewed changes
Copy link
Contributor

@markliby markliby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@SparkYuan SparkYuan merged commit edbc8f8 into KusionStack:main Feb 9, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Feb 9, 2023
@SparkYuan SparkYuan deleted the runtime-import branch June 26, 2023 07:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@markliby markliby markliby approved these changes

@howieyuen howieyuen Awaiting requested review from howieyuen

@healthjyk healthjyk Awaiting requested review from healthjyk

Assignees
No one assigned
Labels
kind/feature Categorizes issue or PR as related to a new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@SparkYuan @coveralls @markliby