Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use reflect pkg to break the limit of for-range by dynamic select/case #240

Merged
merged 1 commit into from
Feb 14, 2023

Conversation

howieyuen
Copy link
Collaborator

@howieyuen howieyuen commented Feb 9, 2023

What type of PR is this?

/kind feature

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #239

Special notes for your reviewer:

Does this PR introduce a user-facing change?

refactor: use reflect pkg to break the limit of for-range by dynamic select/case set

Additional documentation e.g., design docs, usage docs, etc.:

None

@coveralls
Copy link

coveralls commented Feb 9, 2023

Pull Request Test Coverage Report for Build 4132792741

  • 44 of 45 (97.78%) changed or added relevant lines in 1 file are covered.
  • 7 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.1%) to 71.886%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/engine/operation/watch.go 44 45 97.78%
Files with Coverage Reduction New Missed Lines %
pkg/engine/operation/parser/parser.go 3 75.0%
pkg/engine/operation/parser/spec_parser.go 4 66.04%
Totals Coverage Status
Change from base Build 4132501405: 0.1%
Covered Lines: 4646
Relevant Lines: 6463

💛 - Coveralls

@howieyuen howieyuen changed the title use reflect pkg to break the limit of dynamic select/case set use reflect pkg to break the limit of for-range by dynamic select/case Feb 13, 2023
@howieyuen howieyuen enabled auto-merge (squash) February 13, 2023 12:06
Copy link
Contributor

@markliby markliby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@howieyuen howieyuen merged commit d4c20f3 into KusionStack:main Feb 14, 2023
@howieyuen howieyuen deleted the refine-watch branch February 14, 2023 07:55
@github-actions github-actions bot locked and limited conversation to collaborators Feb 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

kusion watch can be optimized by reflect mechanism
3 participants