-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhancement: ignore field support slice type #243
Conversation
daa8dd7
to
9532115
Compare
Pull Request Test Coverage Report for Build 4159591163
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1, add the option to specify the "type" may be better, more flexible;
2, if removeNestedField failed, why no error returned?
3, removeNestedField cannot handle nested field with type which is not map[string]interface{} or []interface{}, it's better to give clear indication of this func is only used for obj generated by json unmarshal, and show the process of json marshal and unmarshal in the test case.
|
I saw the issue already, included the "type" is more useful for me. |
I'll try it again, see is there any better idea to make it. |
What type of PR is this?
/kind feature
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #241
Special notes for your reviewer:
Slice type passes tests, use recursive type assertion can do that.
kind
can not be specified, becauseResourceNode
supports k8s and tf,Type
field is used to differ them.Does this PR introduce a user-facing change?
Additional documentation e.g., design docs, usage docs, etc.: