Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

normalize the Service when importing in k8s runtime #244

Merged
merged 1 commit into from
Feb 13, 2023

Conversation

SparkYuan
Copy link
Member

@SparkYuan SparkYuan commented Feb 13, 2023

What type of PR is this?

/kind feature

What this PR does / why we need it:

add normalizeService in k8s runtime

Special notes for your reviewer:

Does this PR introduce a user-facing change?

normalize Service by delete clusterIP(s) when importing k8s resources

Additional documentation e.g., design docs, usage docs, etc.:


@SparkYuan SparkYuan enabled auto-merge (squash) February 13, 2023 14:10
@SparkYuan SparkYuan changed the title normalize Service in k8s runtime normalize the Service when importing in k8s runtime Feb 13, 2023
@coveralls
Copy link

coveralls commented Feb 13, 2023

Pull Request Test Coverage Report for Build 4164356897

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 10 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.1%) to 71.849%

Files with Coverage Reduction New Missed Lines %
pkg/engine/operation/parser/parser.go 3 75.0%
pkg/cmd/apply/options.go 7 71.2%
Totals Coverage Status
Change from base Build 4163626498: -0.1%
Covered Lines: 4635
Relevant Lines: 6451

💛 - Coveralls

@SparkYuan SparkYuan merged commit a095d9d into KusionStack:main Feb 13, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Feb 13, 2023
@SparkYuan SparkYuan deleted the update-svc-import branch June 26, 2023 07:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants