Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: use golangci-lint github action instead if manual download #245

Merged
merged 1 commit into from
Feb 14, 2023
Merged

chore: use golangci-lint github action instead if manual download #245

merged 1 commit into from
Feb 14, 2023

Conversation

howieyuen
Copy link
Collaborator

@howieyuen howieyuen commented Feb 14, 2023 •
edited

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., design docs, usage docs, etc.:

@howieyuen howieyuen added kind/cleanup clean up codes area/test Categorizes an issue or PR as relevant to test labels Feb 14, 2023
@howieyuen howieyuen enabled auto-merge (squash) February 14, 2023 07:42
@coveralls
Copy link

Pull Request Test Coverage Report for Build 4171540407

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 10 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.02%) to 71.958%
Files with Coverage Reduction New Missed Lines %
pkg/engine/operation/parser/parser.go 3 75.0%
pkg/cmd/apply/options.go 7 71.2%
Totals Coverage Status
Change from base Build 4164433443: -0.02%
Covered Lines: 4642
Relevant Lines: 6451
💛 - Coveralls

markliby
markliby approved these changes Feb 14, 2023
View reviewed changes
Copy link
Contributor

@markliby markliby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@howieyuen howieyuen merged commit bdfbf04 into KusionStack:main Feb 14, 2023
@howieyuen howieyuen deleted the golangci-lint branch February 14, 2023 07:53
@github-actions github-actions bot locked and limited conversation to collaborators Feb 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@markliby markliby markliby approved these changes

Assignees
No one assigned
Labels
area/test Categorizes an issue or PR as relevant to test kind/cleanup clean up codes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@howieyuen @coveralls @markliby