Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: get latest tag from remote not require git credentials #251

Merged
merged 1 commit into from
Feb 22, 2023

Conversation

howieyuen
Copy link
Collaborator

@howieyuen howieyuen commented Feb 16, 2023

What type of PR is this?

/kind bug

Which issue(s) this PR fixes:

Fixes #247

Special notes for your reviewer:

  • use github API to list remote tags
  • make git utils functions private
  • log error when upgrade check failed

Does this PR introduce a user-facing change?

None

Additional documentation e.g., design docs, usage docs, etc.:

None

@coveralls
Copy link

coveralls commented Feb 16, 2023

Pull Request Test Coverage Report for Build 4193570819

  • 40 of 46 (86.96%) changed or added relevant lines in 2 files are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.3%) to 72.411%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/util/gitutil/gitutil.go 40 42 95.24%
pkg/cmd/cmd.go 0 4 0.0%
Files with Coverage Reduction New Missed Lines %
pkg/util/gitutil/gitutil.go 3 89.26%
Totals Coverage Status
Change from base Build 4173273503: 0.3%
Covered Lines: 4685
Relevant Lines: 6470

💛 - Coveralls

@howieyuen howieyuen merged commit 6028ea2 into KusionStack:main Feb 22, 2023
@howieyuen howieyuen deleted the git-cmd branch February 22, 2023 12:31
@github-actions github-actions bot locked and limited conversation to collaborators Feb 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pkg/util/gitutil use git command may cause not found error
3 participants