Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: refactor printers code structure #257

Merged
merged 1 commit into from
Feb 24, 2023

Conversation

howieyuen
Copy link
Collaborator

What type of PR is this?

/kind bug

What this PR does / why we need it:

  • avoid import cycle

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

  • make Convert() and Generate() public
  • avoid import cycle

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., design docs, usage docs, etc.:


@howieyuen howieyuen added kind/bug Something isn't working area/engine labels Feb 24, 2023
@coveralls
Copy link

coveralls commented Feb 24, 2023

Pull Request Test Coverage Report for Build 4260336131

  • 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • 7 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.08%) to 72.349%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/engine/operation/watch.go 0 1 0.0%
Files with Coverage Reduction New Missed Lines %
pkg/cmd/apply/options.go 7 71.2%
Totals Coverage Status
Change from base Build 4242722717: -0.08%
Covered Lines: 4681
Relevant Lines: 6470

💛 - Coveralls

- make Convert() and Generate() public
- avoid import cycle
Copy link
Contributor

@liu-hm19 liu-hm19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@howieyuen howieyuen merged commit 2a26fec into KusionStack:main Feb 24, 2023
@howieyuen howieyuen deleted the refactor-printers branch February 24, 2023 07:46
@github-actions github-actions bot locked and limited conversation to collaborators Feb 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants