Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix invalide hcl file name & optimize tf init time #263

Merged
merged 2 commits into from
Mar 2, 2023

Conversation

SparkYuan
Copy link
Member

What type of PR is this?

/kind bug

What this PR does / why we need it:

The original hcl lock file name is wrong, and I rename it to the right one

image

Special notes for your reviewer:

Does this PR introduce a user-facing change?

None

Additional documentation e.g., design docs, usage docs, etc.:

None

@SparkYuan SparkYuan requested a review from healthjyk March 2, 2023 03:32
@SparkYuan SparkYuan enabled auto-merge (squash) March 2, 2023 03:32
@coveralls
Copy link

Pull Request Test Coverage Report for Build 4310314283

  • 10 of 21 (47.62%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.009%) to 72.356%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/engine/runtime/terraform/terraform_runtime.go 1 2 50.0%
pkg/engine/runtime/terraform/tfops/workspace.go 9 19 47.37%
Totals Coverage Status
Change from base Build 4292838951: -0.009%
Covered Lines: 4680
Relevant Lines: 6468

💛 - Coveralls

@SparkYuan SparkYuan merged commit 7ede4e1 into KusionStack:main Mar 2, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Mar 2, 2023
@SparkYuan SparkYuan changed the title Fix invalide hcl file name Fix invalide hcl file name & optimize tf init time Mar 3, 2023
@SparkYuan
Copy link
Member Author

SparkYuan commented Mar 3, 2023

Close #266

@SparkYuan SparkYuan deleted the fix-hcl-file-name branch June 26, 2023 07:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants