Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

delete redundant codes #323

Merged
merged 1 commit into from
Apr 19, 2023
Merged

delete redundant codes #323

merged 1 commit into from
Apr 19, 2023

Conversation

SparkYuan
Copy link
Member

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

delete redundant codes in spec.go

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?


Additional documentation e.g., design docs, usage docs, etc.:


@SparkYuan SparkYuan requested a review from liu-hm19 April 19, 2023 06:48
@coveralls
Copy link

Pull Request Test Coverage Report for Build 4740383046

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 7 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.03%) to 71.981%

Files with Coverage Reduction New Missed Lines %
pkg/cmd/apply/options.go 7 71.31%
Totals Coverage Status
Change from base Build 4689484256: 0.03%
Covered Lines: 4786
Relevant Lines: 6649

💛 - Coveralls

Copy link
Contributor

@liu-hm19 liu-hm19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SparkYuan SparkYuan merged commit 3a0f50c into KusionStack:main Apr 19, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Apr 19, 2023
@SparkYuan SparkYuan deleted the spec-chore branch June 26, 2023 07:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants