Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle incompatible k8s ingress api change since 1.26.0. #325

Merged
merged 3 commits into from
Apr 24, 2023
Merged

Handle incompatible k8s ingress api change since 1.26.0. #325

merged 3 commits into from
Apr 24, 2023

Conversation

SparkYuan
Copy link
Member

@SparkYuan SparkYuan commented Apr 23, 2023 •
edited

What type of PR is this?

/kind feature

What this PR does / why we need it:

  1. add a new func to handle incompatible k8s ingress api change since 1.26.0.
  2. update related go mods

@SparkYuan SparkYuan requested a review from liu-hm19 April 23, 2023 03:50
@SparkYuan SparkYuan enabled auto-merge (squash) April 23, 2023 03:51
@SparkYuan SparkYuan force-pushed the update-k8s-mod branch 5 times, most recently from d11dcc4 to b2b43b4 Compare April 23, 2023 12:43
@SparkYuan SparkYuan disabled auto-merge April 23, 2023 12:44
@coveralls
Copy link

Pull Request Test Coverage Report for Build 4782287232

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • 7 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.08%) to 71.922%
Files with Coverage Reduction New Missed Lines %
pkg/engine/operation/parser/parser.go 3 78.21%
pkg/engine/operation/parser/spec_parser.go 4 56.1%
Totals Coverage Status
Change from base Build 4782282649: -0.08%
Covered Lines: 4772
Relevant Lines: 6635
💛 - Coveralls

@SparkYuan SparkYuan enabled auto-merge (squash) April 24, 2023 03:59
@SparkYuan SparkYuan disabled auto-merge April 24, 2023 04:00
liu-hm19
liu-hm19 approved these changes Apr 24, 2023
View reviewed changes
Copy link
Contributor

@liu-hm19 liu-hm19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SparkYuan SparkYuan merged commit 97402c2 into KusionStack:main Apr 24, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Apr 24, 2023
@SparkYuan SparkYuan deleted the update-k8s-mod branch June 26, 2023 07:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@liu-hm19 liu-hm19 liu-hm19 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@SparkYuan @coveralls @liu-hm19